Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Python dependency set for the demos/audio flow (notably the speaker-embedding preparation step) by adjusting pinned versions and adding missing direct dependencies required during runtime/model download.
Changes:
- Downgrade pinned
torch/torchaudioversions used by the audio demo requirements. - Adjust
speechbrainversion and addhuggingface_hub/requestsrequirements.
demos/audio/requirements.txt
Outdated
| torch==2.5.1+cpu | ||
| torchaudio==2.5.1+cpu |
There was a problem hiding this comment.
This file pins torch/torchaudio to 2.5.1+cpu, but the audio demo README later installs demos/common/export_models/requirements.txt in the same environment, which pins torch==2.9.1+cpu (and does not pin torchaudio). Installing both requirement sets sequentially will force pip to upgrade/downgrade torch and can break either SpeechBrain or the export script depending on the final resolved versions. Consider aligning the torch (and torchaudio) versions across both requirements files, loosening the pin to a compatible range, or updating the demo instructions to use separate virtual environments for the two steps.
| torch==2.5.1+cpu | |
| torchaudio==2.5.1+cpu | |
| torch==2.9.1+cpu | |
| torchaudio==2.9.1+cpu |
| torch==2.5.1+cpu | ||
| torchaudio==2.5.1+cpu | ||
| speechbrain==1.0.2 | ||
| huggingface_hub<1.0 |
There was a problem hiding this comment.
huggingface_hub<1.0 leaves the exact installed version floating, which can make the demo non-reproducible over time and can change behavior of model downloads unexpectedly. If a specific version is known to work with speechbrain==1.0.2, consider pinning it (or at least adding a tested minimum bound) to stabilize installs.
| huggingface_hub<1.0 | |
| huggingface_hub==0.29.3 |
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``